SDK Performance Boost - #5840
Open
lisandroct wants to merge 9 commits into
Open
Conversation
lisandroct
marked this pull request as draft
August 28, 2026 18:29
lisandroct
force-pushed
the
lisandro/sdk-performance
branch
from
August 31, 2026 14:29
7b86fbb to
4739cb5
Compare
lisandroct
marked this pull request as ready for review
September 1, 2026 19:23
lisandroct
force-pushed
the
lisandro/sdk-performance
branch
from
September 4, 2026 14:33
62fb4b7 to
a4d089f
Compare
JasonAtClockwork
left a comment
Contributor
There was a problem hiding this comment.
I ran into troubles running the PerformanceBenchmarks locally on Windows and WSL. I'll try next week on Linux and reach out if I still have troubles.
| </PropertyGroup> | ||
|
|
||
| <ItemGroup> | ||
| <PackageReference Include="BenchmarkDotNet" Version="0.14.0" /> |
Contributor
There was a problem hiding this comment.
.\sdks\csharp\tests~\test.csproj is currently recursive in loading the tests but doesn't have access to BenchmarkDotNet which causes builds to fail. It might be best to just flag PerformanceBenchmarks as removed in .\sdks\csharp\tests~\test.csproj, such as:
<ItemGroup>
<Compile Remove="PerformanceBenchmarks/**/*.cs" />
</ItemGroup>
| var reducedMultiplicity = (int)my.Multiplicity + before.Delta; | ||
| if (reducedMultiplicity != 0) | ||
| { | ||
| PseudoThrow($"Attempted to apply {their} to {my}, but this resulted in a multiplicity of {reducedMultiplicity}, failing to correctly remove the row before applying the update"); |
Contributor
There was a problem hiding this comment.
It looks like marking PseudoThrow as readonly or static should be fine and clear up all the warnings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
It cleans up a couple of things to achieve better performance in the C# SDK:
.ToArray();API and ABI breaking changes
No changes. It's all internal.
Rollback safety impact
n/a
Expected complexity level and risk
Testing
Benchmarks
I added two benchmarks:
xUnit Benchmarks:
BenchmarkDotNet:
I started with the xUnit benchmark from above and I liked the look of the allocation deltas a lot. But the reducer/procedure time delta didn't look so nice, so I also added this BenchmarkDotNet project that should be a little more accurate and the equivalent benchmark (the first three) now look a lot more flat.